feat(ENG-14143): adding checks for colour and interactivity suppression - #402
Open
coillteoir wants to merge 1 commit into
Open
feat(ENG-14143): adding checks for colour and interactivity suppression#402coillteoir wants to merge 1 commit into
coillteoir wants to merge 1 commit into
Conversation
coillteoir
force-pushed
the
pr402
branch
5 times, most recently
from
September 2, 2026 14:36
9d3fa67 to
1bb052f
Compare
coillteoir
force-pushed
the
pr402
branch
5 times, most recently
from
September 2, 2026 15:44
82ccabb to
9d50d11
Compare
coillteoir
marked this pull request as ready for review
September 3, 2026 13:24
coillteoir
force-pushed
the
pr402
branch
2 times, most recently
from
September 3, 2026 13:27
b161f51 to
0794fb2
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces core utility helpers intended to control ANSI color output and interactive prompting based on environment variables and explicit mode settings, with accompanying unit tests to validate precedence rules.
Changes:
- Added
ColorMode/TTYModeenums pluscolor_enabled()andis_interactive()helpers incloudsmith_cli/core/utils.py. - Added a new test module to exercise environment-variable precedence for color and interactivity suppression.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| cloudsmith_cli/core/utils.py | Adds enums and helper functions to determine whether color and interactive behavior should be enabled. |
| cloudsmith_cli/core/tests/test_terminal_color.py | Adds parametrized tests covering environment-variable precedence for color/interactivity suppression. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Adding checks in the CLI to supporess ANSI output and interactive prompts ## ANSI suppression 1. Check for non-empty `NO_COLOUR` flag 2. Check for `CLOUDSMITH_FORCE_COLOR` flag to enable colour 3. Check for TERM=dumb # Prompt suppression 1. Check for CI=true env var 2. Respect shell TTY conditions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding checks in the CLI to supporess ANSI output and interactive prompts
ANSI suppression
NO_COLOURflagCS_FORCE_TTYflag to enable colour